Handle DAC conversion when using weight_norm with newer PyTorch versions#36393
Merged
vasqu merged 4 commits intohuggingface:mainfrom Jul 10, 2025
Merged
Handle DAC conversion when using weight_norm with newer PyTorch versions#36393vasqu merged 4 commits intohuggingface:mainfrom
vasqu merged 4 commits intohuggingface:mainfrom
Conversation
Contributor
|
cc @kamilakesbi, who made the original conversions (do they still work with the existing conversion scripts?) |
Contributor
Contributor
Author
|
Yes, that PR updates several models including modeling_dac.py to use |
vasqu
approved these changes
Jul 10, 2025
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
Sorry for the late review, this is indeed needed! We also discovered this in #39313 and somehow this PR slipped through :/
A bit unhappy that we have to use a deprecated function but it's kinda forced based on the original weights.
Contributor
|
@bot /style |
Contributor
|
Style bot fixed some files and pushed the changes. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: dac |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
rjgleaton
pushed a commit
to rjgleaton/transformers
that referenced
this pull request
Jul 17, 2025
…ons (huggingface#36393) * Update convert_dac_checkpoint.py * Update convert_dac_checkpoint.py * Apply style fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ons (huggingface#36393) * Update convert_dac_checkpoint.py * Update convert_dac_checkpoint.py * Apply style fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ons (huggingface#36393) * Update convert_dac_checkpoint.py * Update convert_dac_checkpoint.py * Apply style fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ons (huggingface#36393) * Update convert_dac_checkpoint.py * Update convert_dac_checkpoint.py * Apply style fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ons (huggingface#36393) * Update convert_dac_checkpoint.py * Update convert_dac_checkpoint.py * Apply style fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ons (huggingface#36393) * Update convert_dac_checkpoint.py * Update convert_dac_checkpoint.py * Apply style fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ons (huggingface#36393) * Update convert_dac_checkpoint.py * Update convert_dac_checkpoint.py * Apply style fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
zaristei
pushed a commit
to zaristei/transformers
that referenced
this pull request
Sep 9, 2025
…ons (huggingface#36393) * Update convert_dac_checkpoint.py * Update convert_dac_checkpoint.py * Apply style fixes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
nn.utils.weight_normhas been moved tonn.utils.parametrizations.weight_norm. As a result, parametrized layers no longer exposeweight_gorweight_v, but onlyweight. This causes an AttributeError when DAC conversion attempts to access weights:This PR moves
apply_weight_normdirectly into the script, explicitly setting to useweight_norm = nn.utils.weight_normto ensure compatibility.